Pull Request Close Behavior

sturner's Avatar

sturner

06 Nov, 2015 04:11 PM

We are enjoying the latest iteration of Pull Requests in Rhodecode but have a few suggestions:

1. Revamp the "Big Red Button"
No matter what... people click this and are confused by having to comment/vote to close and approve.

2. Allow unapproved P/R's to be closed.
Sometimes we have developers that do not engage in a pull request because they are busy. Ideally they do, and approve or reject the changes. That said, either the creator or administrator of a repository should be able to close or delete an in progress pull request.

Thanks,
Steve

  1. Support Staff 1 Posted by Marcin Kuzminsk... on 07 Nov, 2015 11:52 AM

    Marcin Kuzminski's Avatar

    Hi Steve,

    Thanks for your suggestion we'll discuss this with the team.

    Best,

  2. Support Staff 2 Posted by Marcin Kuzminsk... on 09 Nov, 2015 02:32 PM

    Marcin Kuzminski's Avatar

    Steve,

    In regards to pt 2.

    Deleting a PR is possible from other place if it's an author. You can go to my account -> pull requests. Then you have a list of PR you have created, and you can delete those there.

    But we'll go over both points in details, and try to improve it. The BIG RED BUTTON seems to be problematic not only for you, so we're thinking on leaving it out somehow.

    Best,

  3. sturner closed this discussion on 14 Aug, 2017 09:42 PM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac

Recent Discussions

23 Nov, 2017 03:02 PM
21 Nov, 2017 06:38 PM
03 Oct, 2017 08:26 PM
03 Oct, 2017 05:48 PM
28 Sep, 2017 05:55 PM